Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gateway link using edge gateway worker binding #174

Merged

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Aug 16, 2022

This PR makes nftstorage.link to use new reads pipeline with worker binding to https://github.com/web3-storage/reads/tree/main/packages/edge-gateway . It is quite similar to https://github.com/web3-storage/w3link/tree/main/packages/edge-gateway-link but with different configurations.

Notes:

  • most of the tests live now in the reads pipeline given this repo is mostly an entry point to there for now (future might reserve special features for product specific gateway)
    • this means no need for Docker here for instance, given we do these tests with testcontainers in the reads pipeline
  • worker binding not to perma-cache API but to reads worker (reads worker interacts with the API)
  • use loki for metrics instead of logtail + metrics endpoint
  • durable objects removed 🎉

Needs before merge:

  • secrets setup

@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 16, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f74eb3c
Status: ✅  Deploy successful!
Preview URL: https://1695e9dc.nftstorage-link.pages.dev
Branch Preview URL: https://feat-gateway-link-using-edge.nftstorage-link.pages.dev

View logs

@codecov-commenter
Copy link

Codecov Report

Merging #174 (d270392) into main (b7e918e) will not change coverage.
The diff coverage is n/a.

❗ Current head d270392 differs from pull request most recent head 6c47170. Consider uploading reports for the commit 6c47170 to get more accurate results

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files           4        4           
  Lines         491      491           
=======================================
  Hits          486      486           
  Misses          5        5           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -0,0 +1,63 @@
import fs from 'fs'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just moved to a new file from cli.js

@vasco-santos vasco-santos force-pushed the feat/gateway-link-using-edge-gateway-worker-binding branch from 6c47170 to a0a5bbe Compare August 30, 2022 09:12
@vasco-santos vasco-santos force-pushed the feat/gateway-link-using-edge-gateway-worker-binding branch from a0a5bbe to f74eb3c Compare August 31, 2022 09:53
@vasco-santos vasco-santos merged commit 93d8688 into main Aug 31, 2022
@vasco-santos vasco-santos deleted the feat/gateway-link-using-edge-gateway-worker-binding branch August 31, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants