fix(sf:checkbox): fix invalid trigger check-all when click input (#493)

- close ng-alain/ng-alain#990
ng-alain · Mar 25, 2019 · 4ee3ca5 · 4ee3ca5
1 parent 5e3ad9c
commit 4ee3ca5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/packages/form/src/widgets/checkbox/checkbox.widget.html b/packages/form/src/widgets/checkbox/checkbox.widget.html
@@ -3,8 +3,8 @@
          nz-checkbox
          class="sf__checkbox-all mr-sm"
          [(ngModel)]="allChecked"
-         [nzIndeterminate]="indeterminate"
-         (click)="onAllChecked($event)">{{ ui.checkAllText || l.checkAllText }}</label>
+         (ngModelChange)="onAllChecked()"
+         [nzIndeterminate]="indeterminate">{{ ui.checkAllText || l.checkAllText }}</label>
 </ng-template>
 <sf-item-wrap [id]="id"
               [schema]="schema"

diff --git a/packages/form/src/widgets/checkbox/checkbox.widget.spec.ts b/packages/form/src/widgets/checkbox/checkbox.widget.spec.ts
@@ -78,7 +78,7 @@ describe('form: widget: checkbox', () => {
         },
       });
       const comp = page.getWidget<CheckboxWidget>('sf-checkbox');
-      const checkAllBtn = page.getEl('.sf__checkbox-list .ant-checkbox-wrapper');
+      const checkAllBtn = page.getEl('.sf__checkbox-list .ant-checkbox');
       checkAllBtn.click();
       expect(comp.allChecked).toBe(true);
       checkAllBtn.click();

diff --git a/packages/form/src/widgets/checkbox/checkbox.widget.ts b/packages/form/src/widgets/checkbox/checkbox.widget.ts
@@ -53,8 +53,7 @@ export class CheckboxWidget extends ControlWidget {
     this.notifySet();
   }
 
-  onAllChecked(e: Event) {
-    e.stopPropagation();
+  onAllChecked() {
     this.data.forEach(item => (item.checked = this.allChecked));
     this.notifySet();
   }