Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:st): fix columns can't be re-specified when call export Excel #1181

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Feb 25, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1181 (743a39b) into master (492884f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1181   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         266      266           
  Lines        8018     8019    +1     
  Branches     1602     1603    +1     
=======================================
+ Hits         7724     7725    +1     
  Misses        131      131           
  Partials      163      163           
Impacted Files Coverage Δ
packages/abc/st/st.component.ts 99.54% <ø> (ø)
packages/abc/reuse-tab/reuse-tab.component.ts 94.70% <100.00%> (+0.03%) ⬆️
packages/abc/st/st-export.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492884f...169024a. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Feb 25, 2021

Preview is ready!

@cipchk cipchk merged commit 50baea3 into master Feb 25, 2021
@cipchk cipchk deleted the issues-st-export branch February 25, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants