Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:reuse-tab): support ssr #1232

Merged
merged 1 commit into from
Apr 14, 2021
Merged

fix(abc:reuse-tab): support ssr #1232

merged 1 commit into from
Apr 14, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 14, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Apr 14, 2021

Preview is ready!

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1232 (c96dc4e) into master (c04898a) will decrease coverage by 0.04%.
The diff coverage is 20.00%.

❗ Current head c96dc4e differs from pull request most recent head e378c1d. Consider uploading reports for the commit e378c1d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
- Coverage   96.32%   96.27%   -0.05%     
==========================================
  Files         275      275              
  Lines        8348     8353       +5     
  Branches     1524     1526       +2     
==========================================
+ Hits         8041     8042       +1     
- Misses        139      141       +2     
- Partials      168      170       +2     
Impacted Files Coverage Δ
packages/abc/reuse-tab/reuse-tab.component.ts 92.30% <20.00%> (-2.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04898a...e378c1d. Read the comment docs.

@cipchk cipchk changed the title fix(abc:reuse-tab): supportt ssr fix(abc:reuse-tab): support ssr Apr 14, 2021
@cipchk cipchk merged commit 4933deb into master Apr 14, 2021
@cipchk cipchk deleted the issues-reuse-tab-ssr branch April 14, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants