Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme:menu): refactor MenuService #1507

Merged
merged 8 commits into from
Aug 26, 2022
Merged

refactor(theme:menu): refactor MenuService #1507

merged 8 commits into from
Aug 26, 2022

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@cipchk cipchk changed the title refactor(theme:menu): refactor MenuService draft: refactor(theme:menu): refactor MenuService Jul 15, 2022
@cipchk cipchk changed the title draft: refactor(theme:menu): refactor MenuService draft(theme:menu): refactor MenuService Jul 15, 2022
@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 15, 2022

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1507 (2e378c6) into master (adffdc8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
+ Coverage   95.62%   95.64%   +0.01%     
==========================================
  Files         271      271              
  Lines        8419     8457      +38     
  Branches     1634     1648      +14     
==========================================
+ Hits         8051     8089      +38     
  Misses        307      307              
  Partials       61       61              
Impacted Files Coverage Δ
...kages/theme/layout-default/layout-nav.component.ts 96.96% <100.00%> (-0.16%) ⬇️
packages/theme/src/services/menu/menu.service.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cipchk cipchk changed the title draft(theme:menu): refactor MenuService refactor(theme:menu): refactor MenuService Aug 25, 2022
@cipchk cipchk removed the PR: draft label Aug 25, 2022
@cipchk cipchk merged commit 50f35a9 into master Aug 26, 2022
@cipchk cipchk deleted the issues-2228 branch August 27, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants