Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greek language support added. #423

Merged
merged 3 commits into from
Feb 28, 2019
Merged

Greek language support added. #423

merged 3 commits into from
Feb 28, 2019

Conversation

goten002
Copy link
Contributor

@goten002 goten002 commented Feb 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #423 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   97.27%   97.62%   +0.34%     
==========================================
  Files         257      258       +1     
  Lines        7257     6727     -530     
  Branches     1073      681     -392     
==========================================
- Hits         7059     6567     -492     
+ Misses        125      120       -5     
+ Partials       73       40      -33
Impacted Files Coverage Δ
packages/theme/src/locale/languages/el-GR.ts 100% <100%> (ø)
packages/theme/src/locale/public_api.ts 100% <100%> (ø) ⬆️
packages/form/src/widgets/rate/rate.widget.ts 86.66% <0%> (-0.84%) ⬇️
packages/form/src/widgets/number/number.widget.ts 95.65% <0%> (-0.78%) ⬇️
...kages/form/src/widgets/cascader/cascader.widget.ts 82.14% <0%> (-0.62%) ⬇️
packages/form/src/widgets/array/array.widget.ts 94.73% <0%> (-0.51%) ⬇️
packages/form/src/widgets/object/object.widget.ts 92.85% <0%> (-0.48%) ⬇️
packages/form/src/widgets/upload/upload.widget.ts 95.65% <0%> (-0.19%) ⬇️
...kages/form/src/widgets/checkbox/checkbox.widget.ts 92% <0%> (-0.16%) ⬇️
...rm/src/widgets/autocomplete/autocomplete.widget.ts 97.77% <0%> (-0.14%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a5749...e99c776. Read the comment docs.

@@ -17,6 +17,7 @@ export const LANGS_CONFIG = [
{ langs: ['en'], zorro: 'en_US', delon: 'en_US', fileName: 'en-US.json' },
{ langs: ['tr'], zorro: 'tr_TR', delon: 'tr_TR', fileName: 'tr-TR.json' },
{ langs: ['pl'], zorro: 'pl_PL', delon: 'pl_PL', fileName: 'pl-PL.json' },
{ langs: ['el'], zorro: 'el_GR', delon: 'el_GR', fileName: 'el-GR.json' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fileName value can'n be used, unless provided language pack for ng-alain scaffolding.

@cipchk
Copy link
Member

cipchk commented Feb 27, 2019

@goten002 Hi, can you fix this?

@goten002
Copy link
Contributor Author

@goten002 Hi, can you fix this?

Hello, I just pulled the translated file!

@cipchk cipchk merged commit 17a03d6 into ng-alain:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants