Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:sidebar-nav): fix warnning 'Navigation triggered outside Angu… #466

Merged
merged 1 commit into from
Mar 3, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Mar 3, 2019

…lar zone'

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov-io
Copy link

codecov-io commented Mar 3, 2019

Codecov Report

Merging #466 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         258      258           
  Lines        6757     6757           
  Branches      680      680           
=======================================
  Hits         6696     6696           
  Misses         31       31           
  Partials       30       30
Impacted Files Coverage Δ
packages/abc/sidebar-nav/sidebar-nav.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd0e3f...b267364. Read the comment docs.

@cipchk cipchk merged commit b565b3f into master Mar 3, 2019
@cipchk cipchk deleted the dev-938 branch March 26, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation triggered outside Angular zone
2 participants