Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:reuse-tab): fix exclude items should be updated after leave #925

Merged
merged 1 commit into from
May 26, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented May 26, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #925 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #925   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         233      233           
  Lines        7057     7060    +3     
  Branches     1222     1222           
=======================================
+ Hits         6874     6877    +3     
  Misses        117      117           
  Partials       66       66           
Impacted Files Coverage Δ
packages/abc/reuse-tab/reuse-tab.component.ts 96.64% <100.00%> (+0.02%) ⬆️
packages/abc/reuse-tab/reuse-tab.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94babc6...e879763. Read the comment docs.

@cipchk
Copy link
Member Author

cipchk commented May 26, 2020

Preview is ready!

@cipchk cipchk merged commit e6fef31 into master May 26, 2020
@cipchk cipchk deleted the issues-1673 branch May 26, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

升级angular9后reusetab在mode为URL下没有正确detach Tab
1 participant