Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): add showRequired property of ui schema #940

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented May 31, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented May 31, 2020

Preview is ready!

@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #940 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         233      233           
  Lines        7063     7063           
  Branches     1223     1223           
=======================================
  Hits         6880     6880           
  Misses        117      117           
  Partials       66       66           
Impacted Files Coverage Δ
packages/form/src/model/form.property.factory.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029b5d3...6153f46. Read the comment docs.

@cipchk cipchk merged commit d10f29d into master Jun 2, 2020
@cipchk cipchk deleted the issues-1531 branch June 14, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sf的formData赋值情况下,不满足visibleIf的字段,仍然执行required验证
2 participants