Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart:*): fix access to chart instances #983

Merged
merged 2 commits into from
Jul 3, 2020
Merged

fix(chart:*): fix access to chart instances #983

merged 2 commits into from
Jul 3, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 3, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 3, 2020

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #983 into master will decrease coverage by 0.00%.
The diff coverage is 90.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   96.71%   96.70%   -0.01%     
==========================================
  Files         233      233              
  Lines        7243     7261      +18     
  Branches     1392     1392              
==========================================
+ Hits         7005     7022      +17     
- Misses        141      142       +1     
  Partials       97       97              
Impacted Files Coverage Δ
packages/chart/tag-cloud/tag-cloud.component.ts 34.93% <23.07%> (+0.37%) ⬆️
packages/chart/mini-area/mini-area.component.ts 94.44% <92.85%> (+0.15%) ⬆️
packages/chart/timeline/timeline.component.ts 91.66% <92.85%> (+0.20%) ⬆️
packages/chart/bar/bar.component.ts 91.42% <100.00%> (+0.25%) ⬆️
packages/chart/gauge/gauge.component.ts 96.36% <100.00%> (+0.13%) ⬆️
packages/chart/mini-bar/mini-bar.component.ts 94.11% <100.00%> (+0.24%) ⬆️
packages/chart/pie/pie.component.ts 92.63% <100.00%> (+0.15%) ⬆️
packages/chart/radar/radar.component.ts 97.05% <100.00%> (+0.08%) ⬆️
packages/chart/single-bar/single-bar.component.ts 95.91% <100.00%> (+0.17%) ⬆️
packages/chart/water-wave/water-wave.component.ts 78.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7597300...0167876. Read the comment docs.

@cipchk cipchk merged commit 4a3e80c into master Jul 3, 2020
@cipchk cipchk deleted the issues-1746 branch July 3, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizable G2 Charts
2 participants