Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(form): refining low-frequency widgets #1668

Merged
merged 11 commits into from Nov 9, 2023
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 21, 2023

Breaking Changes

Non-built-in modules, Should be import CascaderWidgetModule in json-schema.module.ts.

  • autocomplete
  • cascader
  • mention
  • rate
  • slider
  • tag
  • transfer
  • tree-select
  • time
  • upload
  • color
  • qr-code
  • segmented

close ng-alain/ng-alain#2093

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Oct 21, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #1668 (398b8b5) into master (b7dbc68) will increase coverage by 0.00%.
The diff coverage is 97.70%.

❗ Current head 398b8b5 differs from pull request most recent head e1f0e3e. Consider uploading reports for the commit e1f0e3e to get more accurate results

@@           Coverage Diff           @@
##           master    #1668   +/-   ##
=======================================
  Coverage   95.53%   95.54%           
=======================================
  Files         282      299   +17     
  Lines        8758     8820   +62     
  Branches     1649     1654    +5     
=======================================
+ Hits         8367     8427   +60     
- Misses        323      325    +2     
  Partials       68       68           
Files Coverage Δ
packages/form/src/module.ts 100.00% <ø> (ø)
packages/form/src/widgets/nz-widget.registry.ts 100.00% <ø> (ø)
packages/form/widgets/autocomplete/index.ts 100.00% <100.00%> (ø)
packages/form/widgets/autocomplete/widget.ts 100.00% <100.00%> (ø)
packages/form/widgets/cascader/index.ts 100.00% <100.00%> (ø)
packages/form/widgets/cascader/widget.ts 100.00% <100.00%> (ø)
packages/form/widgets/color/index.ts 100.00% <100.00%> (ø)
packages/form/widgets/color/widget.ts 100.00% <100.00%> (ø)
packages/form/widgets/mention/index.ts 100.00% <100.00%> (ø)
packages/form/widgets/mention/widget.ts 94.73% <100.00%> (ø)
... and 18 more

... and 1 file with indirect coverage changes

@cipchk cipchk merged commit 8ab0e82 into master Nov 9, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants