Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme:_httpclient): add timestampSecond #1670

Merged
merged 4 commits into from Nov 9, 2023
Merged

feat(theme:_httpclient): add timestampSecond #1670

merged 4 commits into from Nov 9, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #1670 (34eeb42) into master (d9ea22f) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

❗ Current head 34eeb42 differs from pull request most recent head d6ec48c. Consider uploading reports for the commit d6ec48c to get more accurate results

@@            Coverage Diff             @@
##           master    #1670      +/-   ##
==========================================
- Coverage   95.53%   95.52%   -0.01%     
==========================================
  Files         282      282              
  Lines        8758     8761       +3     
  Branches     1649     1652       +3     
==========================================
+ Hits         8367     8369       +2     
  Misses        323      323              
- Partials       68       69       +1     
Files Coverage Δ
packages/theme/src/services/http/http.client.ts 100.00% <100.00%> (ø)
packages/util/date-time/time.ts 97.87% <83.33%> (-2.13%) ⬇️

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Oct 22, 2023

Preview is ready!

@cipchk cipchk merged commit 051b087 into master Nov 9, 2023
8 of 9 checks passed
@cipchk cipchk deleted the issues-2271 branch January 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants