Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abc:st): add trackBy property #1760

Merged
merged 2 commits into from Feb 1, 2024
Merged

feat(abc:st): add trackBy property #1760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9693ab
feat(abc:st): add `trackBy` property
cipchk Feb 1, 2024
74c7300
ci: fix pr number
cipchk Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: jwalton/gh-find-current-pr@v1
- uses: jwalton/gh-find-current-pr@master
id: findPr
with:
state: all
Expand Down
1 change: 1 addition & 0 deletions packages/abc/st/index.en-US.md
View file
Open in desktop
Expand Up @@ -86,6 +86,7 @@ When an exception is thrown when parsing column data, *INVALID DATA* will be for
| `[responsive]` | Whether to turn on responsive | `boolean` | `true` | ✅ |
| `[responsiveHideHeaderFooter]` | Whether to display the header and footer under the small screen | `boolean` | `false` | ✅ |
| `[resizable]` | Resize header of the current table, **Multiple headers not supported** | `STResizable, boolean` | - | - |
| `[trackBy]` | `TrackByFunction` function of list loop `@for` | `TrackByFunction<T>` | - | - |
| `(change)` | Events | `EventEmitter<STChange>` | - | - |
| `(error)` | Error event | `EventEmitter<STError>` | - | - |

Expand Down
1 change: 1 addition & 0 deletions packages/abc/st/index.zh-CN.md
View file
Open in desktop
Expand Up @@ -86,6 +86,7 @@ module: import { STModule } from '@delon/abc/st';
| `[responsive]` | 是否开启响应式 | `boolean` | `true` | ✅ |
| `[responsiveHideHeaderFooter]` | 是否在小屏幕下才显示顶部与底部 | `boolean` | `false` | ✅ |
| `[resizable]` | 当前表格所有列的调整表头配置项，**不支持多表头** | `STResizable, boolean` | - | - |
| `[trackBy]` | `@for` 列表循环的 `TrackByFunction` 函数 | `TrackByFunction<T>` | - | - |
| `(change)` | 变化时回调，包括：`pi`、`ps`、`checkbox`、`radio`、`sort`、`filter`、`click`、`dblClick`、`expand` 变动 | `EventEmitter<STChange>` | - | - |
| `(error)` | 异常时回调 | `EventEmitter<STError>` | - | - |

Expand Down
4 changes: 2 additions & 2 deletions packages/abc/st/st.component.html
View file
Open in desktop
Expand Up @@ -55,7 +55,7 @@
>
@if (showHeader) {
<thead>
@for (row of _headers; track $index) {
@for (row of _headers; track row) {
<tr>
@if ($first && expand) {
<th nzWidth="50px" [rowSpan]="_headers.length"></th>
Expand Down Expand Up @@ -194,7 +194,7 @@
<ng-template [ngTemplateOutlet]="bodyTpl" [ngTemplateOutletContext]="{ $implicit: i, index: index }" />
</ng-template>
} @else {
@for (i of _data; track $index) {
@for (i of _data; track trackBy($index, i)) {
<ng-template [ngTemplateOutlet]="bodyTpl" [ngTemplateOutletContext]="{ $implicit: i, index: $index }" />
}
}
Expand Down
1 change: 1 addition & 0 deletions packages/abc/st/st.component.ts
View file
Open in desktop
Expand Up @@ -225,6 +225,7 @@ export class STComponent implements AfterViewInit, OnChanges {
@Input({ transform: numberAttribute }) virtualMinBufferPx = 100;
@Input() customRequest?: (options: STCustomRequestOptions) => Observable<NzSafeAny>;
@Input() virtualForTrackBy: TrackByFunction<STData> = index => index;
@Input() trackBy: TrackByFunction<STData> = (_, item) => item;

/**
* Get the number of the current page
Expand Down