Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme:yn): fix unable to select parameters #866

Merged
merged 1 commit into from May 1, 2020
Merged

fix(theme:yn): fix unable to select parameters #866

merged 1 commit into from May 1, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented May 1, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Copy link
Member Author

cipchk commented May 1, 2020

Preview is ready!

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #866 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         233      233           
  Lines        6951     6951           
  Branches     1319     1319           
=======================================
  Hits         6772     6772           
  Misses        117      117           
  Partials       62       62           
Impacted Files Coverage Δ
packages/theme/src/pipes/yn/yn.pipe.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea588b2...616bff0. Read the comment docs.

@cipchk cipchk merged commit fa9d0ea into master May 1, 2020
@cipchk cipchk deleted the issues-yn branch May 1, 2020 07:31
goten002 pushed a commit to goten002/delon that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant