Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 NzModalRef 回调值丢失的问题 #1719

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

dusdong
Copy link
Contributor

@dusdong dusdong commented Jun 16, 2020

NzModalRef,先 close(true) 再 destory(),会导致回调值丢失。 在 ng-zorro 8.x 版本中,不存在该问题

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

NzModalRef,先 close(true) 再 destory(),会导致回调值丢失。 在 ng-zorro 8.x 版本中,不存在该问题
@cipchk cipchk changed the title 修复 NzModalRef 回调值丢失的问题 fix: 修复 NzModalRef 回调值丢失的问题 Jun 17, 2020
@cipchk cipchk merged commit 3518308 into ng-alain:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants