Skip to content

Commit

Permalink
refactor: move unnecessary dependencies to devDependencies (#444)
Browse files Browse the repository at this point in the history
The dev-interface had angular dependencies with a specific version listed in its dependencies. In a (npm/yarn) workspace containing another angular version this could cause runtime conflicts as a different version of a angular module could be loaded (Depending on how dependencies are resolved. 

As the dev-interface is already shipping an app build (the dist directory), angular doesn't have to be listed as a dependency as it is a build-time only depdency.
  • Loading branch information
lebbers committed Dec 8, 2022
1 parent 4ea9fab commit 6041db8
Showing 1 changed file with 13 additions and 15 deletions.
28 changes: 13 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,16 @@
"recording"
],
"devDependencies": {
"@angular/animations": "13.2.0",
"@angular/cdk": "13.2.0",
"@angular/common": "13.2.0",
"@angular/compiler": "13.2.0",
"@angular/core": "13.2.0",
"@angular/forms": "13.2.0",
"@angular/material": "13.2.0",
"@angular/platform-browser": "13.2.0",
"@angular/platform-browser-dynamic": "13.2.0",
"@angular/router": "13.2.0",
"@angular-devkit/build-angular": "13.2.0",
"@angular-eslint/builder": "13.0.1",
"@angular-eslint/eslint-plugin": "13.0.1",
Expand Down Expand Up @@ -92,24 +102,12 @@
"protractor": "7.0.0",
"protractor-cucumber-framework": "8.2.11",
"rimraf": "3.0.2",
"rxjs": "7.5.2",
"semantic-release": "19.0.2",
"tslib": "2.3.1",
"ts-node": "10.4.0",
"typescript": "4.5.5",
"wait-on": "6.0.0"
},
"dependencies": {
"@angular/animations": "13.2.0",
"@angular/cdk": "13.2.0",
"@angular/common": "13.2.0",
"@angular/compiler": "13.2.0",
"@angular/core": "13.2.0",
"@angular/forms": "13.2.0",
"@angular/material": "13.2.0",
"@angular/platform-browser": "13.2.0",
"@angular/platform-browser-dynamic": "13.2.0",
"@angular/router": "13.2.0",
"rxjs": "7.5.2",
"tslib": "2.3.1",
"wait-on": "6.0.0",
"zone.js": "~0.11.4"
},
"lint-staged": {
Expand Down

0 comments on commit 6041db8

Please sign in to comment.