-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate angular 17 #517
Migrate angular 17 #517
Conversation
stefanoslig
commented
Nov 18, 2023
•
edited
edited
- Angular 17
- Standalone component
- Lazy loaded routes
- Tiny rebranding
Hi @stefanoslig thanks for starting this pr. Do you need any help? |
Hey @mdasberg . Thanks for reaching out! What I need is a PR review when you have time. Also, I'm not sure if you agree with the tiny rebranding of the app I did in order to be closer to the new brand of Angular. I still need to check that everything works as expected( unit, e2e tests, etc). I'll try to do this during this week |
Hi @mdasberg ! I noticed that the unit tests are failing also in the master branch. I think it's better fix them in a separate branch. Could you please check my changes and merge the PR if you agree with them? |
@stefanoslig I fixed the unit tests on your branch. |
That's great! If you need help with this, let me know |
# [3.3.0](v3.2.1...v3.3.0) (2023-11-30) ### Features * migrate angular 17 ([#517](#517)) ([00b07c7](00b07c7))
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks a lot for all the work you did in the PR @mdasberg!! 💪 |