refactor schedule page to be an NgModule #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamVerschueren
force-pushed
the
modularize
branch
from
d63ee41
to
fdea8eb
Compare
|
they indeed just take all scss and bundle it .. |
| display: inline-block; | ||
| padding: 2px 4px 4px 4px; | ||
| font-size: 0.8em; | ||
| margin-right: 5px; |
There was a problem hiding this comment.
very small remark: group:
margin: {
right: 5px;
bottom: 5px;
}
There was a problem hiding this comment.
Cool, didn't know that was possible :)
samvloeberghs
approved these changes
Jan 24, 2017
samvloeberghs
changed the title
Which is weird. It's not how Angular 2 works imo. I'm going to check this and maybe create an issue in the Ionic repository. Ionic is nothing special, I don't see a reason why it wouldn't be technically possible. |
SamVerschueren
force-pushed
the
modularize
branch
from
fdea8eb
to
46ec332
Compare
|
Fixed. |
samvloeberghs
changed the title
|
Code looks nice and clean. Great work @SamVerschueren 👍 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started doing the refactoring work. I already did most of the schedule page. We might be able to extract some more components but I think this already is a nice improvement. I wasn't able to leverage
ChangeDetectionStrategy.OnPushbecause the data isn't immutable. Might be a nice addition in the future.Please provide feedback of any kind. Namings (variables, functions, components, ...), code, ...
P.S. I don't like how Ionic handles styling. You don't have to specify the stylesheet in your component. It looks like it just takes all the SCSS files and compiles them into one big main file without view encapsulation. Might be possible though, have to look into it.