Skip to content

Commit

Permalink
fix(nav): NgbNavLinkBase matches multiple times
Browse files Browse the repository at this point in the history
`NgbNavLinkBase` was matched both via selector and applied as `hostDirective` on the same element.

Fixes #4594
  • Loading branch information
maxokorokov committed Nov 6, 2023
1 parent ee48a6b commit 02ab48b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/nav/nav.ts
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,6 @@ export class NgbNavLinkBase {
@Directive({
selector: 'button[ngbNavLink]',
standalone: true,
hostDirectives: [NgbNavLinkBase],
host: {
type: 'button',
'[disabled]': 'navItem.disabled',
Expand All @@ -461,7 +460,6 @@ export class NgbNavLinkButton extends NgbNavLinkBase {}
@Directive({
selector: 'a[ngbNavLink]',
standalone: true,
hostDirectives: [NgbNavLinkBase],
host: {
href: '',
'(click)': 'nav.click(navItem); $event.preventDefault()',
Expand Down

0 comments on commit 02ab48b

Please sign in to comment.