Skip to content

Commit

Permalink
feat(datepicker): remove deprecated 'select' output (#3887)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: datepicker `(select)` output  deprecated in 6.0.0 is now removed

Before:

```
<ngb-datepicker (select)="inDateSelect($event)"></ngb-datepicker>
```

After:

```
<ngb-datepicker (dateSelect)="inDateSelect($event)"></ngb-datepicker>
```
  • Loading branch information
maxokorokov committed Nov 3, 2020
1 parent 681c1e3 commit 0662d4d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion src/datepicker/datepicker-month.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const createTestComponent = () => createGenericTestComponent(
[showWeekdays]="showWeekdays"
[showWeekNumbers]="showWeekNumbers"
[outsideDays]="outsideDays"
(select)="onClick($event)">
(dateSelect)="onClick($event)">
<ng-template #dt let-date="date">{{ date.day }}</ng-template>
</ngb-datepicker>
`,
Expand Down
10 changes: 0 additions & 10 deletions src/datepicker/datepicker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,16 +299,6 @@ export class NgbDatepicker implements OnDestroy,
*/
@Output() dateSelect = new EventEmitter<NgbDate>();

/**
* An event emitted when user selects a date using keyboard or mouse.
*
* The payload of the event is currently selected `NgbDate`.
*
* @deprecated 6.0.0 Please use 'dateSelect' output instead due to collision with native
* 'select' event.
*/
@Output() select = this.dateSelect;

onChange = (_: any) => {};
onTouched = () => {};

Expand Down

0 comments on commit 0662d4d

Please sign in to comment.