fix(progressbar): reorder 'value' and 'max' attribute bindings for IE

Closes #543 Closes #544
ng-bootstrap · Aug 4, 2016 · 30e20f5 · 30e20f5
1 parent 359b9b8
commit 30e20f5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/progressbar/progressbar.spec.ts b/src/progressbar/progressbar.spec.ts
@@ -76,9 +76,15 @@ describe('ng-progressbar', () => {
 
            expect(getBarWidth(fixture.nativeElement)).toBe('10%');
 
+           // this might fail in IE11 if attribute binding order is not respected for the <progress> element:
+           // <progress [value]="" [max]=""> will fail with value = 1
+           // <progress [max]="" [value]=""> will work with value = 10
+           expect(getProgressbar(fixture.nativeElement).getAttribute('value')).toBe('10');
+
            fixture.componentInstance.value = 30;
            fixture.detectChanges();
            expect(getBarWidth(fixture.nativeElement)).toBe('30%');
+           expect(getProgressbar(fixture.nativeElement).getAttribute('value')).toBe('30');
          });
        })));
 

diff --git a/src/progressbar/progressbar.ts b/src/progressbar/progressbar.ts
@@ -11,7 +11,7 @@ import {getValueInRange, toBoolean} from '../util/util';
     <progress class="progress {{type ? 'progress-' + type : ''}}" 
       [class.progress-animated]="isAnimated()" 
       [class.progress-striped]="isStriped()"
-      [value]="getValue()" [max]="max">
+      [max]="max" [value]="getValue()">
       <div class="progress">
         <span class="progress-bar" [style.width.%]="getPercentValue()"><ng-content></ng-content></span>
       </div>