Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressbar: broken in IE11 with value always = 1 #543

Closed
maxokorokov opened this issue Aug 4, 2016 · 3 comments
Closed

Progressbar: broken in IE11 with value always = 1 #543

maxokorokov opened this issue Aug 4, 2016 · 3 comments

Comments

@maxokorokov
Copy link
Member

Always generates progressbars with value=1

Screenshot from the demo:
progress

Generated html:

<progress value="1" max="100" ng-reflect-value="50" ng-reflect-max="100"> ... </progress>

From (MDN):

  • if the max is not set value should be between 0 and 1
  • if the max is set value should be between 0 and max

So looks like this template causes the issue (from progressbar.ts):

<progress [value]="getValue()" [max]="max" ... >

Because this seem to work:

<progress [max]="max" [value]="getValue()"  ... >

Apparently after setting value to, say 50, IE limits it to 1, because max is not yet there.

Not sure if it's the best solution though

@pkozlowski-opensource
Copy link
Member

Are you saying that order of attributes matter???

@maxokorokov
Copy link
Member Author

@pkozlowski-opensource yep, it this case yes... so that's why I'm not sure what to do with this information yet :)

@pkozlowski-opensource
Copy link
Member

Sight... IE... So it seems like it has some internal state and fails to update it properly.... If swapping order makes IE happy and doesn't hurt other browsers, let's make this change. I'm not sure we've got other way of controlling order of bindings...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants