Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type definition file error 1.0.0-alpha.12 #1027

Closed
scttcper opened this issue Nov 10, 2016 · 6 comments
Closed

type definition file error 1.0.0-alpha.12 #1027

scttcper opened this issue Nov 10, 2016 · 6 comments

Comments

@scttcper
Copy link

I'm seeing /// <reference types="core-js" /> in 1.0.0-alpha.12 from modal-ref.d.ts

ERROR in [default] ./node_modules/@ng-bootstrap/ng-bootstrap/modal/modal-ref.d.ts:1:0
Cannot find type definition file for 'core-js'.
@pkozlowski-opensource
Copy link
Member

@scttcper are you sung TS 1.8 by any chance?

@Foxandxss could this by side effect of migration to types?

@scttcper
Copy link
Author

I'm using angular-cli latest beta 19-3. Comes with ts ~2.0.3

@pkozlowski-opensource
Copy link
Member

@scttcper we've recently migrated to @types (https://blogs.msdn.microsoft.com/typescript/2016/06/15/the-future-of-declaration-files/) so this is probably a side effect of it.

We need to investigate to understand what is going on exactly but in the meantime you can go back to alpha.11....

@scttcper
Copy link
Author

@pkozlowski-opensource
i think you'll have to drop @types/core-js
It will throw errors for promises, ect.. but you can silence those by adding "lib": ["es6", "dom"] to the tsconfig.

Might also need

"types": ["node"]

but i'm not sure.

@pkozlowski-opensource
Copy link
Member

@scttcper you are correct, we've just figured it out. We are going to fix it and cut a new release in a few hours.

@pkozlowski-opensource
Copy link
Member

alpha.13 with the fix should be on npm now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants