Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typeahead): do not trap keydown enter event #1032

Closed
wants to merge 1 commit into from
Closed

feat(typeahead): do not trap keydown enter event #1032

wants to merge 1 commit into from

Conversation

deeg
Copy link
Contributor

@deeg deeg commented Nov 11, 2016 •
edited
Loading

  • selectItem should not be fired when nothing is selected
  • we do not do preventDefault() on keydown.enter when there is nothing selected
  • we do preventDefault() and stopPropagation() when there are things to select.

Closes #958
Closes #877
Closes #980

@pkozlowski-opensource
Copy link
Member

Merged, thnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeg @pkozlowski-opensource