fix(buttons): proerly handle disabled propery on a button level

[pkozlowski-opensource]

Fixes #1088
Fixes #1089

[alex321]

This certainly solves #1089.

The only thing missing is when you change the group state from disabled to enabled, you'll enable all buttons I think, even if they are bound to disabledRadio = true. That could be a separate issue though.

You are still doing side-effects in the set ^ ^

[pkozlowski-opensource]

The only thing missing is when you change the group state from disabled to enabled, you'll enable all buttons I think, even if they are bound to disabledRadio = true. That could be a separate issue though.

Yep, there are more corner cases I can think of - I will open separate issues for those.

You are still doing side-effects in the set ^ ^

Side effects in a setter are fine, I was complaining about side effect in a getter (or at least this was my intention :-))

I'm going to go ahead and merge this one as it solves reported issues and doesn't introduce new problems. But yeh, we should have separate issues for more corner cases we've identified. Thnx for your pull request - even if it is not merged it made me better understand the underlying issue and fix options!

[alex321]

@pkozlowski-opensource At least I tried. :)
I am quite happy to get any buttons or other issues assigned and give them a shot. I've got some spare time around the holidays.

[pkozlowski-opensource]

At least I tried. :)
I am quite happy to get any buttons or other issues assigned and give them a shot. I've got some spare time around the holidays.

This is what I call open source spirit, thnx @alex321 ! I've just opened #1143 so it might be a good issue to play with as you know the code and problems right now. But of course any help is more than appreciated. Feel free to ping me on GitHub if you are stuck on anything.

Thnx again!