Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled buttons corner cases #1143

Closed
pkozlowski-opensource opened this issue Dec 15, 2016 · 1 comment
Closed

Disabled buttons corner cases #1143

pkozlowski-opensource opened this issue Dec 15, 2016 · 1 comment

Comments

@pkozlowski-opensource
Copy link
Member

While investigating button-related issues I could spot some corner cases around the disabled state handling:

  • it is possible to enable an individual button even if the entire group is disabled
  • switching group from disabled => enabled re-enables all buttons, even the ones that are explicitly disabled.

We should probably re-think disabled state propagation from a group to individual buttons (keep both buttons and group state and calculate final states based on the 2).

@alex321
Copy link
Contributor

alex321 commented Dec 16, 2016

@pkozlowski-opensource Thanks #1141, I think I've got this in a few lines. Just need to write 1 or 2 tests and I'll create a PR (probably now but if not then tomorrow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants