Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Bootstrap alpha 6. Dropdown now open with class Show instead of Open #1180

Closed
ASHFAQPATWARI opened this issue Jan 7, 2017 · 2 comments
Closed

Support for Bootstrap alpha 6. Dropdown now open with class Show instead of Open #1180

ASHFAQPATWARI opened this issue Jan 7, 2017 · 2 comments

Comments

@ASHFAQPATWARI
Copy link

Bug description:

Dropdown does not work with bootstrap v4 - alpha 6.

Open class on dropdown needs to changed to show

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/RpzceTvZq90NJ9zN7ZWp?p=preview

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 2.4.1

ng-bootstrap: alpha-16

Bootstrap: v4 - alpha 6
jnizet added a commit to jnizet/ng-bootstrap that referenced this issue Jan 7, 2017
@jnizet
chore(dropdown): upgrade to 4.0.0-alpha.6
c4f626f 
refs ng-bootstrap#1178
fix ng-bootstrap#1180
@jnizet jnizet mentioned this issue Jan 7, 2017
Closed
@ASHFAQPATWARI
Copy link
Author

@jnizet Modals are also not working for the same reason.

@pkozlowski-opensource
Copy link
Member

This will be solved as part of #1178

pkozlowski-opensource pushed a commit that referenced this issue Jan 9, 2017
@jnizet @pkozlowski-opensource
feat(dropdown): upgrade to 4.0.0-alpha.6
d8bfe37 
refs #1178
fix #1180
Closes #1182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkozlowski-opensource @ASHFAQPATWARI