Feature: Add input to ngbRadioGroup for allowing vertical group

[adamk33n3r]

It would be nice to specify whether we want it to be a .btn-group or a btn-vertical-group 😄

[pkozlowski-opensource]

Why not. PRs welcomed - this should be rather simple change.

[dmytroyarmak]

@pkozlowski-opensource What do you think would be better?

1. Ask developer to specify class on [ngbRadioGroup] manually (don't set host's class on ngbRadioGroup element at all)
2. Add parameter
   a. Add "orientation" parameter that should be "horizontal" (default) or "vertical"
   b. Add "vertical" parameter that should be true or false (default)

[pkozlowski-opensource]

@dmytroyarmak my preference would go to (1) or (2a). Not sure which of the 2 is better.

Here are pros / cons for (1):

• (+) don't need new API
• (+) doesn't use binding
• (-) requires more typing for the typical case
• (-) breaking change (we don't care too much as this is still alpha)

If you take (2a) pros / cons are pretty much reversed as compared to (1)....

What would be your pick?

[dmytroyarmak]

@pkozlowski-opensource
I think it's better to do (2a) to not introduce breaking change

[pkozlowski-opensource]

I think it's better to do (2a) to not introduce breaking change

@dmytroyarmak let's do it! Fancy putting together a PR?

[dmytroyarmak]

@pkozlowski-opensource yeah, I'll do a PR later today.

[pkozlowski-opensource]

Update: I've decided to rather go with the option (1) from #1231 (comment)

In addition to the mentioned "pros" it will keep radio and checkboxes implementation consistent.