-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabset): add nav justification and orientation #1239
Conversation
src/tabset/tabset.ts
Outdated
if (className === 'fill' || className === 'justified') { | ||
this.justifyClass = 'nav-' + className; | ||
} else { | ||
this.justifyClass = 'justify-content-' + className; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could pretty the class setting to
this.justifyClass = `nav-${className}`;
and
this.justifyClass = `justify-content-${className}`;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like this needs to be rebased, but otherwise should be good. |
someone wanna rebase it and added it if it's good (assuming that's the only thing stopping the commit)? I'd do it myself if i could but @ktriek hasn't made a comment in almost 2 months. |
This seems to be a very useful feature. Thanks |
What's the status of this PR? I need this to be able to use ng-bootstrap for tabs since it finally implements missing features. |
Hi, when is this coming along? |
Merged, thnx a lot @ktriek ! Sorry it took as so long but we were busy with other items and waiting for Bootstrap 4 beta to see if there are no more changes coming. Once again, thnx for the PR - we love PRs with tests, demo updates and clean code. Keep them coming! |
Thanks @pkozlowski-opensource for your time, I really appreciate what you are doing. |
Tabset is deprecated in favor of nav and it seems that nav-justified is not working on nav.
does not produce the expected behavior. |
start
: align left.justify-content-start
center
: align center.justify-content-center
end
: align right.justify-content-end
fill
: All horizontal space will be occupied by nav links.nav-fill
justified
: All horizontal space will be occupied by nav links and every nav item will be the same width.nav-justified
horizontal
vertical
Before submitting a pull request, please make sure you have at least performed the following: