Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advice] Tabs fill and justify #1472

Closed
justforuse opened this issue Apr 11, 2017 · 3 comments
Closed

[Advice] Tabs fill and justify #1472

justforuse opened this issue Apr 11, 2017 · 3 comments

Comments

@justforuse
Copy link

Not bug, just my advice.

For now, bootstrap4 has already supported tabs fill and justify, Here is the link: http://v4-alpha.getbootstrap.com/components/navs/#fill-and-justify

And you can just add .nav-fill class on ngb-tabset to make tabs justified, Here is the plnkr:
http://plnkr.co/edit/4q7RdiwhTMPtbjnq9leW?p=preview , it performs well.

Maybe it's better to add 'fill' or other words to NgbTabsetConfig.justify, while it only support 'start', 'end' and 'center'

Thanks a lot

@pkozlowski-opensource
Copy link
Member

Related #1239

@Adondriel
Copy link

Just, info for anyone else using the Tabs, if you set a tab's [id] value to an object, it ACTUALLY WORKS on the tab change event.(Might be nice to add this info to the documentation) I was blown away when I figured this out.

@justforuse
Copy link
Author

@Adondriel sorry I don't get it.. is this related to this issue? what does tab's [id] do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants