Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(progressbar): Add labels to progressbars #1259

Closed
wants to merge 1 commit into from
Closed

feat(progressbar): Add labels to progressbars #1259

wants to merge 1 commit into from

Conversation

ktriek
Copy link
Contributor

@ktriek ktriek commented Jan 26, 2017 •
edited

Fix #1251

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

thbt
thbt approved these changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@thbt thbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@pkozlowski-opensource
Copy link
Member

LGTM as well.

@pkozlowski-opensource
Copy link
Member

Merged, thnx!

thbt pushed a commit to thbt/ng-bootstrap that referenced this pull request Jan 27, 2017
feat(progressbar): Show current value of progressbar
0270c19 
improve upon ng-bootstrap#1259
fix ng-bootstrap#1251
thbt pushed a commit to thbt/ng-bootstrap that referenced this pull request Jan 27, 2017
feat(progressbar): Show current value of progressbar
e59ac50 
improve upon ng-bootstrap#1259
fix ng-bootstrap#1251
thbt pushed a commit to thbt/ng-bootstrap that referenced this pull request Jan 27, 2017
feat(progressbar): Show current value of progressbar
199db8a 
improve upon ng-bootstrap#1259
fix ng-bootstrap#1251
@thbt thbt mentioned this pull request Jan 27, 2017
Closed
5 tasks
pkozlowski-opensource pushed a commit that referenced this pull request Feb 1, 2017
@pkozlowski-opensource
feat(progressbar): Show current value of progressbar
83e01de 
improve upon #1259
fix #1251

Closes #1269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbt thbt thbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ktriek @pkozlowski-opensource @thbt