Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rateChange fires on ngbRating when element is pristine #1282

Closed
SanderElias opened this issue Feb 1, 2017 · 1 comment
Closed

rateChange fires on ngbRating when element is pristine #1282

SanderElias opened this issue Feb 1, 2017 · 1 comment
Labels
component: rating type: bug
Milestone
1.0.0-alpha.21

Comments

@SanderElias
Copy link

Bug description:

when you using the rating the rateChange event fires when the element is still pristime

Link to minimally-working plunker that reproduces the issue:

link

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 2.4.5
ng-bootstrap: latest
Bootstrap: 4.0.0-alpha.6
@pkozlowski-opensource
Copy link
Member

I can confirm that this is a valid bug. The root cause here is that we are not accounting for the initial change detection. The fix should consist of detecting initial CD and not propagating event in this case.

fbasso pushed a commit to fbasso/ng-bootstrap that referenced this issue Feb 8, 2017
fix(rating): prevent rateChange to be fired when element is pristine
aeb4222 
Close ng-bootstrap#1282
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this issue Feb 8, 2017
fix(rating): prevent rateChange to be fired when element is pristine
5a54568 
Close ng-bootstrap#1282
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this issue Feb 8, 2017
fix(rating): prevent rateChange to be fired when element is pristine
bc88243 
Close ng-bootstrap#1282
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this issue Feb 8, 2017
fix(rating): prevent rateChange to be fired when element is pristine
5b35460 
Close ng-bootstrap#1282
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this issue Feb 8, 2017
fix(rating): prevent rateChange to be fired when element is pristine
345de0c 
Close ng-bootstrap#1282
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this issue Feb 9, 2017
fix(rating): prevent rateChange to be fired when element is pristine
bbdb97f 
Close ng-bootstrap#1282
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this issue Feb 9, 2017
fix(rating): prevent rateChange to be fired when element is pristine
1d46afb 
Close ng-bootstrap#1282
@fbasso fbasso mentioned this issue Feb 9, 2017
Closed
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this issue Feb 9, 2017
fix(rating): prevent rateChange to be fired when element is pristine
611d665 
Close ng-bootstrap#1282
Closed
@pkozlowski-opensource pkozlowski-opensource added this to the 1.0.0-alpha.21 milestone Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: rating type: bug
Projects
None yet
Milestone
1.0.0-alpha.21
Development

No branches or pull requests
2 participants
@pkozlowski-opensource @SanderElias