New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): handle collapsed days/weeks properly #1383

Closed

maxokorokov wants to merge 1 commit into ng-bootstrap:master from maxokorokov:dp_fix_collapse

Member

maxokorokov commented Mar 16, 2017

Fixing the following things:

broken day collapse after flexbox migration (see datepicker: outsideDays='collapsed' not collapsing empty space #1377)
broken week collapse (collapsed week not displayed anymore even when [showWeekNumbers]="true")
displaying hidden/collapsed days with [ngIf] as opposed to display: none; or visibility: hidden;
adding tests to check what actually is displayed as days


          fix(datepicker): handle collapsed days/weeks properly

f6d54aa

Fixes ng-bootstrap#1377

maxokorokov added component: datepicker needs: review labels

maxokorokov added this to the 1.0.0-alpha.22 milestone

pkozlowski-opensource closed this in

4f54bfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment