Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabs: improve accessibility #1430

Closed
thbt opened this issue Apr 3, 2017 · 0 comments
Closed

tabs: improve accessibility #1430

thbt opened this issue Apr 3, 2017 · 0 comments
Labels
component: tab type: accessibility

Comments

@thbt
Copy link
Contributor

thbt commented Apr 3, 2017

Bug description

Disabled tabs are not announced as disabled and should not be focusable.

Solution

The easy fix would be to add aria-dsabled="true" and tabindex="-1" to the tab title link or replacing it by a span element.

However it is not clear yet how bootstrap will address this issue as they are thinking about removing ARIA attributes twbs/bootstrap#19738
@thbt thbt changed the title tabs: improve tabs accessibility tabs: improve accessibility Apr 3, 2017
@thbt thbt mentioned this issue Apr 3, 2017
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tab type: accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs): prevent focus of disabled tabs thbt/ng-bootstrap
2 participants
@pkozlowski-opensource @thbt