Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow or add option to bind user-defined class to Popover host #1441

Closed
manju-reddys opened this issue Apr 5, 2017 · 3 comments
Closed

Allow or add option to bind user-defined class to Popover host #1441

manju-reddys opened this issue Apr 5, 2017 · 3 comments
Labels
component: popover type: feature

Comments

@manju-reddys
Copy link

manju-reddys commented Apr 5, 2017 •
edited

Bug description:

Currently there is not way to add a user-defined class to the popover host.

Allowing to add user-defined class make life easier to customize (styling) the popover content as needed otherwise it will be patch work to to change the popover appearance.

We can style the popover content but not the popover itself. Its not a good idea to alter the popover globally so allowing to bind the custom class make life easy.

Link to minimally-working plunker that reproduces the issue:

Plunker

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: V-4

ng-bootstrap: 1.0.0-alpha.22

Bootstrap: 4.0.0-alpha.6

custom-view
mattlewis92 pushed a commit to mattlewis92/ng-bootstrap that referenced this issue Jun 2, 2017
feat(popover): allow a custom css class to be added
e074f02 
Closes ng-bootstrap#1441
@mattlewis92 mattlewis92 mentioned this issue Jun 2, 2017
Closed
5 tasks
mattlewis92 pushed a commit to mattlewis92/ng-bootstrap that referenced this issue Jun 3, 2017
feat(popover): allow a custom css class to be added
1280f48 
Closes ng-bootstrap#1441
@goshoo
Copy link

goshoo commented Oct 19, 2017

I'm also interested in this feature. I need to modify popover's width (CSS "max-width" parameter).

@shyamal890
Copy link

+1

swseverance added a commit to swseverance/ng-bootstrap that referenced this issue Apr 12, 2018
@swseverance
feat(popover): add popoverClass option
4f1d9c0 
* provide class applied to `NgbPopoverWindow` via input to
  `NgbPopover` or via `NgbPopoverConfig`
* add example usage to demo app

Closes ng-bootstrap#1441
@swseverance swseverance mentioned this issue Apr 12, 2018
Closed
5 tasks
@pierre-hilt
Copy link

Hello, it could be very great to have this kind of options for all components with a window.

Modal, typeahead, popover...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: popover type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@goshoo @pkozlowski-opensource @manju-reddys @shyamal890 @pierre-hilt