Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker navigation by keyboard #1708

Closed
Yura13 opened this issue Jul 27, 2017 · 6 comments
Closed

Datepicker navigation by keyboard #1708

Yura13 opened this issue Jul 27, 2017 · 6 comments

Comments

@Yura13
Copy link

Yura13 commented Jul 27, 2017

Currently, datepicker doesn't support navigation by press arrows and selecting a date by press enter.

@pkozlowski-opensource
Copy link
Member

What do you mean? It does support the mentioned keyboard navigation, see http://plnkr.co/edit/G8aOFqOGjZtvvnSzvDQE?p=preview

Please follow submission guidelines when opening new issues: https://github.com/ng-bootstrap/ng-bootstrap#you-think-youve-found-a-bug

@pkozlowski-opensource
Copy link
Member

Closing for now. Happy to re-open when you've got more info and a reproduce scenario in a plunker.

@Yura13
Copy link
Author

Yura13 commented Jul 27, 2017

Here is the example in plunker:
http://plnkr.co/edit/0LCfDA?p=preview

Datepicker is open after click on button or input, but when trying to navigate by keyboard does not provide any result.

Navigation by keyboard works only if you click somewhere on opened datepicker(for example you can click on - Mo, Tu, We, Th, Fr, Sa, Su; do not click on dropdowns, buttons, dates). And it is confused and not useful.

@pkozlowski-opensource
Copy link
Member

Oh, you mean datepicker in popup! I guess it is a matter of bringing focus to the datepicker calendar when it gets opened.

@maxokorokov
Copy link
Member

@Yura13, true. If you do the shift-tab after opening the popup - it will focus the datepicker. I also think we should simply bring focus to it after opening.

@maxokorokov
Copy link
Member

Opened a PR to focus the datepicker by default when opening inside the popup.
Further discussion focus/keyboard handling improvements should move to #1716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants