New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): focus datepicker after opening it inside the popup #1717

Closed

maxokorokov wants to merge 1 commit into ng-bootstrap:master from maxokorokov:datepicker_focus

Member

maxokorokov commented Jul 31, 2017

The datepicker will de focused when opened in the popup, so keyboard navigation would work right from the start without clicking on anything first
Introduce focus() method to programmatically focus datepicker

For this to work synchronously the default tabindex: 0 is required on the datepicker

Fixes #1708


          fix(datepicker): focus datepicker after opening it inside the popup

19361c4

Fixes ng-bootstrap#1708

maxokorokov added component: datepicker needs: review labels

pkozlowski-opensource modified the milestone: 1.0.0-alpha.30

Member

pkozlowski-opensource commented Aug 1, 2017

LGTM

pkozlowski-opensource closed this in

0dbe0cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment