Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngOutletContext is depricated and has been removed from Angular 5.0.0-beta.5 #1791

Closed
gregbown opened this issue Aug 30, 2017 · 2 comments
Closed

Comments

@gregbown
Copy link

Bug description:

The ngOutletContext is removed from Angular 5.0.0-beta.5 and causes AOT build errors due to its use in date picker, rating and type ahead

From Angular CHANGELOG
common: NgTemplateOutlet#ngOutletContext has been removed as it was deprecated since v4. Use NgTemplateOutlet#ngTemplateOutletContext instead.

As an interim fix I edited these [
typeahead-window.js,
typeahead-window.metadata.json,
datepicker-month-view.js,
datepicker-month-view.metadata.json,
rating.js,
rating.metadata.json
]

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: Angular 5.0.0-beta.5

ng-bootstrap: 1.0.0-beta.2

Bootstrap: 4

@pkozlowski-opensource
Copy link
Member

Wooooops, you are right. I was sure that we've updated all the deprecated API calls already, but seems like we've missed this one. Thnx for reporting.

I've just sent a PR to correct the issue (#1792) - the fix will be part of the next release.

@pkozlowski-opensource
Copy link
Member

It is fixed in master now, I will cut a patch release later today. Once again, thnx for reporting!

rmeans pushed a commit to fcsa-teamhammer/ng-bootstrap that referenced this issue Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants