Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngbRadioGroup doesn't mark the form control as touched #1987

Closed
jnizet opened this issue Nov 24, 2017 · 0 comments
Closed

ngbRadioGroup doesn't mark the form control as touched #1987

jnizet opened this issue Nov 24, 2017 · 0 comments

Comments

@jnizet
Copy link
Member

jnizet commented Nov 24, 2017

Bug description:

When a ngbRadioGroup (or, rather, one of its buttons) loses the focus, the underlying form control should be marked as touched. But it isn't. This is important to me because in case no option is selected, and the form control is marked as required, I want to display an error message only when the control has been touched.

I'll submit a PR to fix this.

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/YNagzOqkgIBymo0amPVq?p=preview

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 4.0.3 or 5.0.x

ng-bootstrap: 1.0.0-beta.5

Bootstrap: 4.0.0-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant