Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position of popover is slightly shifted (again) #2089

Closed
kubica opened this issue Jan 16, 2018 · 0 comments · Fixed by #3006
Closed

Position of popover is slightly shifted (again) #2089

kubica opened this issue Jan 16, 2018 · 0 comments · Fixed by #3006
Labels
component: popover component: tooltip type: bug
Milestone
4.0.3

Comments

@kubica
Copy link

kubica commented Jan 16, 2018

Bug description:

This issue is directly related to #1845. After updating to 1.0.0-beta.9 the popover arrow is not shown at the middle of the element again (see picture).

Alternativer Text

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/TC8fYac0G7OLmlKvqWf7?p=preview

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 5.0.2

ng-bootstrap: 1.0.0-beta.9

Bootstrap: 4.0.0-beta.3
@pkozlowski-opensource pkozlowski-opensource added this to the 1.0.1 milestone Jan 29, 2018
@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.0.1, 1.0.2 Mar 2, 2018
@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.0.2, 1.0.3, 1.1.1 Mar 19, 2018
@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.1.1, 1.1.2 Apr 6, 2018
@dmi3lab dmi3lab mentioned this issue Apr 27, 2018
Closed
@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.1.2, 2.1.1, 2.1.2 Jun 13, 2018
@pkozlowski-opensource pkozlowski-opensource modified the milestones: 2.1.2, 2.2.1 Jun 22, 2018
@maxokorokov maxokorokov removed this from the 2.2.1 milestone Jul 3, 2018
@fbasso fbasso mentioned this issue Feb 7, 2019
Merged
@maxokorokov maxokorokov added this to the 4.0.3 milestone Feb 7, 2019
maxokorokov pushed a commit that referenced this issue Feb 7, 2019
@fbasso @maxokorokov
fix(popover): arrow is correctly centered
a613fa9 
Closes #3006
Fixes #2089
Fixes #2234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: popover component: tooltip type: bug
Projects
None yet
Milestone
4.0.3
Development

Successfully merging a pull request may close this issue.

fix(popover): arrow positioning issues fbasso/ng-bootstrap
3 participants
@pkozlowski-opensource @kubica @maxokorokov