Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New components Toast and Spinner with Bootstrap 4.2 #2201

Closed
bastienmoulia opened this issue Mar 1, 2018 · 7 comments
Closed

New components Toast and Spinner with Bootstrap 4.2 #2201

bastienmoulia opened this issue Mar 1, 2018 · 7 comments

Comments

@bastienmoulia
Copy link
Contributor

Should we consider to include components for Toast and maybe Spinner (like a modal) as Bootstrap 4.1 should integrate them?

See twbs/bootstrap#22980 and twbs/bootstrap#22960

@pkozlowski-opensource
Copy link
Member

@bastienmoulia totally! I can see how JS / logic will be needed for Toast.
Not sure about spinners , though - isn't it only CSS?

In any case, yes - we want to have those! Feel free to start prototyping if you feel like doing so!

@mauricew
Copy link

mauricew commented Mar 7, 2018

I decided to get started with an initial implementation and have modified docs up. The Bootstrap implementation isn't done yet (there's no toast-dismissible class) and this is new territory for conventions to be established, so it certainly needs work.

@Foxandxss
Copy link
Member

Lovely that they are adding new components. I love toasts

@bastienmoulia
Copy link
Contributor Author

@mauricew: I came to the same conclusion, the best thing to do is to work first on the toast implementation in bootstrap.

@pkozlowski-opensource
Copy link
Member

So, it looks like those components are still work in progress on the Bootstrap side, adding links here for the reference:

@pkozlowski-opensource pkozlowski-opensource changed the title New components Toast and Spinner with Bootstrap 4.1 New components Toast and Spinner with Bootstrap 4.2 Jul 20, 2018
@kukac7
Copy link
Contributor

kukac7 commented Aug 31, 2018

toast is coming 😱 twbs/bootstrap#22980 (comment)

@benouat
Copy link
Member

benouat commented Jun 24, 2019

Closing as Bootstrap 4.3.1 has landed with #3220

Closes #2945

@benouat benouat closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants