New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI with Angular 8 #3220
CI with Angular 8 #3220
Conversation
This comment has been minimized.
This comment has been minimized.
d5f4618
to
357f2f0
Compare
357f2f0
to
fcd5307
Compare
Well, there are definitely some positioning issues when running tests in parallel (exactly 18px on the Y axis, if you see logs).
|
Codecov Report
@@ Coverage Diff @@
## master #3220 +/- ##
=========================================
- Coverage 92.04% 90.14% -1.9%
=========================================
Files 91 91
Lines 3054 2700 -354
Branches 505 503 -2
=========================================
- Hits 2811 2434 -377
- Misses 179 207 +28
+ Partials 64 59 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I updated some stuff via the latest 2 commits:
- fallbacking the
es5
target for testing in IE (mostly duplicated some configs files for Saucelabs) - making the build green with positioning tests (needed to add bootstrap styles to karma)
The goal of this PR is to make CI pass with Angular 8 (without ivy)
{static: true/false}
for queriespopover-1
depending on test execution orderPlease see separate commits and don't squash when merging
Fixes #3213