Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker: (dateSelect) not firing #2278

Closed
ryu323 opened this issue Apr 3, 2018 · 1 comment
Closed

Datepicker: (dateSelect) not firing #2278

ryu323 opened this issue Apr 3, 2018 · 1 comment
Assignees
@maxokorokov
Labels
component: datepicker type: bug
Milestone
1.1.1

Comments

@ryu323
Copy link

ryu323 commented Apr 3, 2018

Bug description:

Regarding:
https://ng-bootstrap.github.io/#/components/datepicker/api#NgbInputDatepicker

Not sure if I'm missing something, but (dateSelect) does not seem to fire when a date is selected from the datepicker.

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/tPNBc3ROOD2Cna7no6Ro?p=preview

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 5.2.9

ng-bootstrap: 1.1.0

Bootstrap: 4.0.0
@pkozlowski-opensource pkozlowski-opensource added this to the 1.1.1 milestone Apr 3, 2018
@maxokorokov maxokorokov self-assigned this Apr 4, 2018
@maxokorokov
Copy link
Member

Thanks, this is the case when all unit tests are fine, but integration is missing...

Both (ngModelChange) and (selectDate) are emitted, but looks like input datepicker first gets the model change and kills the datepicker before receiving the select event. Will see how to fix soon.

maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 5, 2018
@maxokorokov
fix(datepicker): emit 'selectEvent' when datepicker model changes
52a8a11 
Fixes ng-bootstrap#2278
@maxokorokov maxokorokov mentioned this issue Apr 5, 2018
Closed
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 5, 2018
@maxokorokov
fix(datepicker): emit 'selectEvent' when datepicker model changes
c154acd 
Fixes ng-bootstrap#2278
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 5, 2018
@maxokorokov
fix(datepicker): emit 'selectEvent' when datepicker model changes
9f928ee 
Fixes ng-bootstrap#2278
pld000 pushed a commit to devhousellc/core that referenced this issue May 7, 2018
@maxokorokov @pld000
fix(datepicker): emit 'selectEvent' when datepicker model changes
2cc76f4 
Fixes ng-bootstrap#2278

Closes ng-bootstrap#2281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxokorokov maxokorokov

Labels
component: datepicker type: bug
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
3 participants
@ryu323 @pkozlowski-opensource @maxokorokov