-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can escape Modals to reach background using Screen Readers #2575
Milestone
Comments
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Jan 14, 2019
Add missing 'aria-modal' on the modal window. Add 'aria-hidden' on all sibling DOM branches from the modal window up to the document body Fixes ng-bootstrap#2575
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Jan 14, 2019
Add missing 'aria-modal' on the modal window. Add 'aria-hidden' on all sibling DOM branches from the modal window up to the document body Fixes ng-bootstrap#2575
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Jan 14, 2019
Add missing 'aria-modal' on the modal window. Add 'aria-hidden' on all sibling DOM branches from the modal window up to the document body Fixes ng-bootstrap#2575
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Jan 17, 2019
Add missing 'aria-modal' on the modal window. Add 'aria-hidden' on all sibling DOM branches from the modal window up to the document body Fixes ng-bootstrap#2575
Unfortunately adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description:
Can escape Modals to reach background using Voice Over/JAWS
Steps,
The Modal is launched on top of the original modal.
Note, I've only tested this in Voice Over, but other screen readers should have the same behaviour on different Operating Systems. For most greenfield desktop browsers, setting
aria-modal="true"
, (introduced in aria 1.1), on the same div with therole="dialog"
should fix the issue. For older browsers, the only solution is to setaria-disabled="true"
on the root of the background content.Also, note this is different from the previous issue asking to add a tab trap
More info on aria-modal
Link to minimally-working plunker that reproduces the issue:
Here
Version of Angular, ng-bootstrap, and Bootstrap:
Angular:
Angular 6.0.4
ng-bootstrap:
2.2.2
Bootstrap:
4.1.1
The text was updated successfully, but these errors were encountered: