Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug): Datepicker updates a model twice when clearing an input #2642

Closed
AbakumovAlexandr opened this issue Aug 24, 2018 · 0 comments · Fixed by #2684
Closed

(bug): Datepicker updates a model twice when clearing an input #2642

AbakumovAlexandr opened this issue Aug 24, 2018 · 0 comments · Fixed by #2684
Labels
component: datepicker type: bug
Milestone
3.2.1

Comments

@AbakumovAlexandr
Copy link

Bug description:

When completely clearing text in the input via Backspace\Del buttons, Datepicker immediately updates a model with null value and after that the second time when losing focus.

Simple input does not do so the second time on focus lost.

Link to minimally-working plunker that reproduces the issue:

Stackblitz.

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 6.1.2

ng-bootstrap: 3.1.0

Bootstrap: 4.1.1
@AbakumovAlexandr AbakumovAlexandr changed the title (bug): Datepicker emits value change twice when clearing an input (bug): Datepicker updates a model twice when clearing an input Aug 24, 2018
divdavem added a commit to divdavem/ng-bootstrap that referenced this issue Sep 4, 2018
@divdavem
fix(datepicker): avoid updating the model twice (on input and on change)
cd57659 
close ng-bootstrap#2642
@divdavem divdavem mentioned this issue Sep 4, 2018
Merged
5 tasks
@maxokorokov maxokorokov added this to the 3.2.1 milestone Sep 13, 2018
maxokorokov pushed a commit that referenced this issue Sep 13, 2018
@divdavem @maxokorokov
fix(datepicker): avoid updating the model twice (on input and on change)
b44c6d7 
Fixes #2642
Closes #2684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: datepicker type: bug
Projects
None yet
Milestone
3.2.1
Development

Successfully merging a pull request may close this issue.

fix(datepicker): avoid updating the model twice (on input and on change) divdavem/ng-bootstrap
3 participants
@pkozlowski-opensource @AbakumovAlexandr @maxokorokov