Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timepicker): chevron width and height must match #2674

Merged
merged 1 commit into from Sep 11, 2018
Merged

fix(timepicker): chevron width and height must match #2674

merged 1 commit into from Sep 11, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2018

Fixes #2663

When width and height of the chevron don't match, the chevron might look chopped off at some root font sizes

Default root font-size: 16px:
image
image

Custom root font-size: 12px:
image
image

When width and height are equal, rendered chevron looks fine with any root font-size:
image
image

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!
Looks like it was cropped in IE even with default size...

@maxokorokov maxokorokov merged commit 2d6a586 into ng-bootstrap:master Sep 11, 2018
@ghost ghost deleted the fix-timepicker-chevron-size branch September 12, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants