Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): avoid updating the model twice (on input and on change) #2684

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented Sep 4, 2018

This PR fixes #2642

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

It behaves as a normal input for me now.

@maxokorokov maxokorokov merged commit b44c6d7 into ng-bootstrap:master Sep 13, 2018
@divdavem
Copy link
Member Author

@maxokorokov Thank you for your review and for integrating my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug): Datepicker updates a model twice when clearing an input
2 participants