fix(accordion): don't submit HTML form when toggling panels #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benouat
requested changes
Oct 5, 2018
src/accordion/accordion.ts
Outdated
| @@ -116,7 +116,8 @@ export interface NgbPanelChangeEvent { | |||
| <div class="card"> | |||
| <div role="tab" id="{{panel.id}}-header" [class]="'card-header ' + (panel.type ? 'bg-'+panel.type: type ? 'bg-'+type : '')"> | |||
| <h5 class="mb-0"> | |||
| <button class="btn btn-link" (click)="!!toggle(panel.id)" [disabled]="panel.disabled" [class.collapsed]="!panel.isOpen" | |||
| <button type="button" class="btn btn-link" | |||
| (click)="!!toggle(panel.id)" [disabled]="panel.disabled" [class.collapsed]="!panel.isOpen" | |||
There was a problem hiding this comment.
You could remove the !! here as it is not needed anymore. It used to be needed when the <button> was an <a>.
Returning false to prevent default only work on <a> tag (and it is not standard, and should not be used anymore BTW).
On a button it is effect-less. Main issue here was definitely only related to the missing type.
There was a problem hiding this comment.
Good point @benouat - thnx, removed it.
maxokorokov
approved these changes
Oct 5, 2018
|
@maxokorokov thnx, it is merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2760
I've also checked all other widgets and all seems fine - only accordion was missing
type="button"