Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Angular 7 support #2764

Closed
4 of 5 tasks
pkozlowski-opensource opened this issue Oct 5, 2018 · 7 comments
Closed
4 of 5 tasks

Update for Angular 7 support #2764

pkozlowski-opensource opened this issue Oct 5, 2018 · 7 comments
Milestone

Comments

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Oct 5, 2018

  • update documentation extraction script to support TS 3.1.x
  • (warning) tslint version with CLI 7 marks keyEvent.which as deprecated
  • (warning) demo: tslint version with CLI 7 marks addListener as deprecated
  • update documentation with supported versions in README.md and getting-started.component.ts
  • required tsickle 0.33.0 gives a peer-depencency warning after installation with CLI 7.0.0 and TS 3.1.1
@maxokorokov
Copy link
Member

maxokorokov commented Oct 12, 2018

Opened #2791 to test, CI works fine, demos look fine, looks like current 3.x.x should work fine.

@changhuixu
Copy link

After update to Angular v7,

npm WARN @ng-bootstrap/ng-bootstrap@3.3.0 requires a peer of @angular/common@^6.1.0 but none is installed. You must install peer dependencies yourself.
npm WARN @ng-bootstrap/ng-bootstrap@3.3.0 requires a peer of @angular/core@^6.1.0 but none is installed. You must install peer dependencies yourself.
npm WARN @ng-bootstrap/ng-bootstrap@3.3.0 requires a peer of @angular/forms@^6.1.0 but none is installed. You must install peer dependencies yourself.

@maxokorokov
Copy link
Member

@changhuixu by saying that 3.x.x should work fine, I meant that there are no breaking changes / development required in the library to support Angular 7. Warnings is a different thing.

We'll release 4.0.0 shortly with official support for Angular 7.0.0, rxjs 6.3.0 and TS 3.1.1 that will remove all warnings in question.

@danielleroux
Copy link

@maxokorokov Did you mean that you will allow both angular versions 6.1.0 and 7.0.0?

...
"@angular/core": "6.1.0 || 7.0.0",
...

@jamesnvk
Copy link

jamesnvk commented Oct 22, 2018

I'm currently receiving this error when trying to upgrade to angular 7:

$ng update @angular/cli @angular/core
                  Package "@ng-bootstrap/ng-bootstrap" has an incompatible peer dependency to "@angular/forms" (requires "^5.0.2" (extended), would install "7.0.0").
                  Package "@ng-bootstrap/ng-bootstrap" has an incompatible peer dependency to "@angular/core" (requires "^5.0.2" (extended), would install "7.0.0").
                  Package "@ng-bootstrap/ng-bootstrap" has an incompatible peer dependency to "@angular/common" (requires "^5.0.2" (extended), would install "7.0.0").
Incompatible peer dependencies found. See above.

Update:
Make sure you update your ng bootstrap before updating to Angular 7
ng update @ng-bootstrap/ng-bootstrap
then
ng update @angular/cli @angular/core

should work

@pkozlowski-opensource
Copy link
Member Author

Just released Angular 7 compatible version - aca4cbe

@muhammadarifinnursalim
Copy link

I got the same problem and I have tried this method:

delete your node module folder then
delete your package-lock.json file
run npm install
run ng serve -o
This works for me, I hope you do too :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants