Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(buttons): pre-checked value doesn't work with ChangeDetectionStrategy.OnPush #2980

Closed
ghost opened this issue Jan 21, 2019 · 0 comments · Fixed by #3000
Closed

bug(buttons): pre-checked value doesn't work with ChangeDetectionStrategy.OnPush #2980

ghost opened this issue Jan 21, 2019 · 0 comments · Fixed by #3000
Labels
component: buttons type: bug
Milestone
4.0.3

Comments

@ghost
Copy link

ghost commented Jan 21, 2019

  1. Open stackblitz demo
  2. Press Tab to trigger change detection

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 7.0.0
ng-bootstrap: 4.0.1
@maxokorokov maxokorokov added this to the 4.0.3 milestone Jan 23, 2019
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Feb 4, 2019
@maxokorokov
fix(buttons): reflect initial ngModel value inside OnPush component
8d3ec66 
Fixes ng-bootstrap#2980
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Feb 4, 2019
@maxokorokov
fix(buttons): display correct NgModel value inside OnPush component
aa72873 
Fixes ng-bootstrap#2980
@maxokorokov maxokorokov mentioned this issue Feb 4, 2019
Merged
maxokorokov added a commit that referenced this issue Feb 11, 2019
@maxokorokov
fix(buttons): display correct NgModel value inside OnPush component (#…
083fb0f 
…3000)

Fixes #2980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: buttons type: bug
Projects
None yet
Milestone
4.0.3
Development

Successfully merging a pull request may close this issue.

fix(buttons): display correct NgModel value inside OnPush component maxokorokov/ng-bootstrap
2 participants
@benouat @maxokorokov